chore: Ensures advanced configuration updates trigger wait for completion #2954
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lantoli
reviewed
Jan 13, 2025
| _, _, err := connV220240530.ClustersApi.UpdateClusterAdvancedConfiguration(ctx, projectID, clusterName, ¶ms20240530).Execute() | ||
| if err != nil { | ||
| return diag.FromErr(fmt.Errorf(errorConfigUpdate, clusterName, err)) | ||
| } | ||
| } | ||
| if !reflect.DeepEqual(params, admin.ClusterDescriptionProcessArgs20240805{}) { | ||
| advancedConfigChanged = true |
There was a problem hiding this comment.
what about waiting in each change, similarly to TPF impl, potentially taking more time, but minimizing possible problems because of race conditions in Atlas?
There was a problem hiding this comment.
Yes, changed in d57f751
lantoli
approved these changes
Jan 13, 2025
lantoli
approved these changes
Jan 13, 2025
EspenAlbert
deleted the
CLOUDP-293895_TestAccMockableAdvancedCluster_waitForAdvancedConfigUpdates
branch
lantoli
added a commit
that referenced
this pull request
Jan 16, 2025
* master: doc: Uses weekly option in cloud backup schedule documentation (#2963) chore: Bump tj-actions/verify-changed-files (#2965) chore: Bump srvaroa/labeler from 1.12.0 to 1.13.0 (#2966) chore: Bump peter-evans/create-pull-request from 7.0.5 to 7.0.6 (#2967) chore: Bump github.com/pb33f/libopenapi from 0.19.1 to 0.20.0 (#2968) chore: Bump github.com/zclconf/go-cty from 1.16.0 to 1.16.1 (#2969) fix: Updates test to use old schema for data sources in AWS provider configuration (#2962) chore: Uses backend default for zoneName to make tenantUpgrade pass on SDKv2 (#2952) chore: Refactors test checks to only run for TPF due to `[]` in SDKv2 for computed specs (#2955) chore: Ensures advanced configuration updates trigger wait for completion (#2954) chore: Remove usage of fixed 2024-08-05 version in cluster resource and ensure auto scaling mode is not impacted (#2918) chore: Updates CHANGELOG.md for #2953 feat: Adds support for disabling Backup Compliance Policy on resource delete (#2953) chore: Improves Makefile help (#2958)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Ensures advanced configuration updates trigger wait for completion
Link to any related issue(s): CLOUDP-293895
Type of change:
Required Checklist:
Further comments